Conditions | 1 |
Paths | 1 |
Total Lines | 90 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | var chai = require('chai'); |
||
64 | describe("isTrue", function () { |
||
65 | it('properly eval ==', function() { |
||
66 | var value1 = 'str1', |
||
67 | operator = '==', |
||
68 | value2 = 'str1', |
||
69 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
70 | expected = true; |
||
71 | chai.expect(rendered).to.eql(expected); |
||
72 | }); |
||
73 | it('properly eval ==', function() { |
||
74 | var value1 = 'str1', |
||
75 | operator = '==', |
||
76 | value2 = 'str2', |
||
77 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
78 | expected = false; |
||
79 | chai.expect(rendered).to.eql(expected); |
||
80 | }); |
||
81 | it('properly eval ===', function() { |
||
82 | var value1 = '1', |
||
83 | operator = '===', |
||
84 | value2 = 1, |
||
85 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
86 | expected = false; |
||
87 | chai.expect(rendered).to.eql(expected); |
||
88 | }); |
||
89 | it('properly eval <', function() { |
||
90 | var value1 = 1, |
||
91 | operator = '<', |
||
92 | value2 = 10, |
||
93 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
94 | expected = true; |
||
95 | chai.expect(rendered).to.eql(expected); |
||
96 | }); |
||
97 | it('properly eval <=', function() { |
||
98 | var value1 = 10, |
||
99 | operator = '<=', |
||
100 | value2 = 10, |
||
101 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
102 | expected = true; |
||
103 | chai.expect(rendered).to.eql(expected); |
||
104 | }); |
||
105 | it('properly eval &&', function() { |
||
106 | var value1 = null, |
||
107 | operator = '&&', |
||
108 | value2 = 10, |
||
109 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
110 | expected = false; |
||
111 | chai.expect(rendered).to.eql(expected); |
||
112 | }); |
||
113 | it('properly eval &&', function() { |
||
114 | var value1 = [], |
||
115 | operator = '&&', |
||
116 | value2 = 10, |
||
117 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
118 | expected = false; |
||
119 | chai.expect(rendered).to.eql(expected); |
||
120 | }); |
||
121 | it('properly eval &&', function() { |
||
122 | var value1 = {"var":"1"}, |
||
123 | operator = '&&', |
||
124 | value2 = {"other":"1"}, |
||
125 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
126 | expected = true; |
||
127 | chai.expect(rendered).to.eql(expected); |
||
128 | }); |
||
129 | it('properly eval ||', function() { |
||
130 | var value1 = null, |
||
131 | operator = '||', |
||
132 | value2 = 10, |
||
133 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
134 | expected = true; |
||
135 | chai.expect(rendered).to.eql(expected); |
||
136 | }); |
||
137 | it('properly eval ||', function() { |
||
138 | var value1 = [], |
||
139 | operator = '||', |
||
140 | value2 = null, |
||
141 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
142 | expected = false; |
||
143 | chai.expect(rendered).to.eql(expected); |
||
144 | }); |
||
145 | it('properly eval ||', function() { |
||
146 | var value1 = false, |
||
147 | operator = '||', |
||
148 | value2 = 4, |
||
149 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
150 | expected = true; |
||
151 | chai.expect(rendered).to.eql(expected); |
||
152 | }); |
||
153 | }); |
||
154 | describe("setVariable", function () { |
||
163 | }); |